build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33016 )
Change subject: src/driver/vpd: Update lib_vpd from upstream ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/33016/4/src/drivers/vpd/lib_vpd.c File src/drivers/vpd/lib_vpd.c:
https://review.coreboot.org/#/c/33016/4/src/drivers/vpd/lib_vpd.c@88 PS4, Line 88: if (VPD_OK != retval) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/33016/4/src/drivers/vpd/lib_vpd.c@104 PS4, Line 104: if (VPD_OK != retval) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/33016/4/src/drivers/vpd/lib_vpd.c@122 PS4, Line 122: break; break is not useful after a goto or return