Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81102?usp=email )
Change subject: mb/google/nissa/var/anraggar: Add pen insert/remove for wakeup
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81102/comment/ba9f7a2c_62c02267 :
PS1, Line 7: insert
insert/remove
Done
https://review.coreboot.org/c/coreboot/+/81102/comment/688c3d06_198140f0 :
PS1, Line 9: Achieve stylus can wake both insert and remove.
Please start by describing the problem, and solution: […]
Done
https://review.coreboot.org/c/coreboot/+/81102/comment/204b9f21_f392499f :
PS1, Line 10:
Please say, why `ANY` is correct.
Done
https://review.coreboot.org/c/coreboot/+/81102/comment/43d8c808_f1b5c520 :
PS1, Line 12: can wakeup system
wakes system up.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icdea995c2be04ea459e985f79269e49faf88248d
Gerrit-Change-Number: 81102
Gerrit-PatchSet: 3
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 15 Mar 2024 02:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment