[coreboot-gerrit] Change in coreboot[master]: mainboard/google: Allow Hatch variants to read SPD data over SMBus

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )

Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/romstage_spd_smbus.c:

https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... 
PS2, Line 27: GPIO_MEM_CH_SEL
I don't think we need this for boards reading SPD via SMBus.

https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... 
PS2, Line 48: 	memcfg.spd[0].read_type = READ_SMBUS;
yes, I think we should just use get_spd_smbus() and pass in the data into FSP.
> Thanks for catching this, I wonder if we should make a patch to ensure other platforms do this in a consistent manner as a separate thing?

That can be done as a follow-up.