Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31503 )
Change subject: drivers/intel/gma: Add `new-pch.asl` for Skylake+
......................................................................
Patch Set 1: Code-Review+1
Changing brightness is a little buggy (no visual feedback of icons and meter and there's a disconnect between brightness controlled by keys (calling GMA) and a Linux-controlled knob) but it works.
Creating a follow-up to link it up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b21d9a0288f0f8d6cb0a4776909bffdae7576f5
Gerrit-Change-Number: 31503
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Mar 2020 21:00:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment