[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree

[Rex Chou (Code Review)]

Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Ian Feng, Kenny Pan, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli.

Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email )

Change subject: mb/google/nissa/var/craaskov: Add overridetree
......................................................................

Patch Set 10:

(17 comments)

File src/mainboard/google/brya/variants/craaskov/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76662/comment/2200bada_e1018c1d :
PS9, Line 79:                 device ref i2c1 on
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/1eed69e4_73b57a5d :
PS9, Line 81:                                 register "generic.hid" = ""ELAN9004""
            :                                 register "generic.desc" = ""ELAN Touchscreen""
            :                                 register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
            :                                 register "generic.probed" = "1"
            :                                 register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
            :                                 register "generic.reset_delay_ms" = "20"
            :                                 register "generic.reset_off_delay_ms" = "2"
            :                                 register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
            :                                 register "generic.enable_delay_ms" = "1"
            :                                 register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
            :                                 register "generic.stop_delay_ms" = "150"
            :                                 register "generic.stop_off_delay_ms" = "2"
            :                                 register "generic.has_power_resource" = "1"
            :                                 register "hid_desc_reg_offset" = "0x01"
            :                                 device i2c 10 on end
> use tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/f30eca04_2a20387c :
PS9, Line 98:
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/2afc7f75_ba980bd4 :
PS9, Line 110:
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/c8db7705_8bd36833 :
PS9, Line 111:
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/4683eb10_6f01b1ef :
PS9, Line 131:
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/d8abc487_ec9d531c :
PS9, Line 176:                                                 register "use_custom_pld" = "true"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/736a0514_eaa884a7 :
PS9, Line 177:                                                 register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/f76200a9_183cbc78 :
PS9, Line 183:                                                 register "use_custom_pld" = "true"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/2ac02ec5_9b339859 :
PS9, Line 184:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/45e0a2ad_fd9edb66 :
PS9, Line 190:                                                 register "use_custom_pld" = "true"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/afda517f_100224db :
PS9, Line 191:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/7d58696d_6ced20cd :
PS9, Line 206:                                         chip drivers/usb/acpi
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/3e5085d7_37f3e841 :
PS9, Line 215:                                                 register "use_custom_pld" = "true"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/9e9efb1d_8a579055 :
PS9, Line 216:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/66b6184e_fa37a2fd :
PS9, Line 222:                                                 register "use_custom_pld" = "true"
> tab

Done

https://review.coreboot.org/c/coreboot/+/76662/comment/588c4f0b_dc8b6795 :
PS9, Line 223:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))"
> tab

Done