Attention is currently required from: Bao Zheng, ritul guru, Zheng Bao.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: amdfwtool: Allow the location to be a relative address
......................................................................
Patch Set 17:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69856/comment/c20b8df2_12850d0c
PS17, Line 2499: /* Relative address. */
What does this comment mean? Is it for the things above the comment? If it's for things below the comment, maybe move it after the break?
https://review.coreboot.org/c/coreboot/+/69856/comment/76208804_d1ad7d3a
PS17, Line 2505: /* Special cases for 8M */
What if a ROM smaller than 8MiB is used on an older platform? Would we need more special cases?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c
Gerrit-Change-Number: 69856
Gerrit-PatchSet: 17
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Sun, 05 Feb 2023 18:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment