Hello Felix Singer, build bot (Jenkins), Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39765
to look at the new patch set (#15).
Change subject: mb/up/squared: rewrite GPIO config using intelp2m ......................................................................
mb/up/squared: rewrite GPIO config using intelp2m
This format of PCH GPIOs configuration, unlike the raw DW0 and DW1 registers values from the inteltool dump, is more understandable and makes the code much cleaner. This configuration was generated using the Intel Pad 2 Macro utility (intelp2m / pch-pads-parser) [1,2].
GPIORXDIS, GPIOTXDIS RX and RXEVCFG fields in the DW0 register do not affect the pad in native function, and PAD_CFG_NF_IOSSTATE_IOSTERM() does not set the value of these fields. They will be ignored during conversion.
[1] https: //github.com/maxpoliak/pch-pads-parser [2] https: //review.coreboot.org/c/coreboot/+/35643
Change-Id: I266ec6fa10a9691a7b7d3cd6f2792624e8bd53d5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/up/squared/gpio.h 1 file changed, 505 insertions(+), 506 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/39765/15