Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Scott Chao, Shou-Chieh Hsu, Tarun Tuli.
Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email )
Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/joxer/ramstage.c:
https://review.coreboot.org/c/coreboot/+/76773/comment/3502cd46_abf04323 :
PS3, Line 20: static void update_oem_variables(void)
why don't you just put this in variant.c? IMHO, no need for extra file.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167
Gerrit-Change-Number: 76773
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 01 Aug 2023 11:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment