[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add SPI GPIO driving setting

[Mengqi Zhang (Code Review)]

Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )

Change subject: mediatek/mt8183: Add SPI GPIO driving setting
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/gpio.c@140 
PS2, Line 140: 0x4
> Where does this 0x4 come from? Is this a drive strength? Or a bit field? A comment about what exactl […]

0x4 means 10mA drive strength. This drive strength value depends on the real board design, so it can't be suitable all boards.I have modified this interface, please review the latest patch.