Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38343 )
Change subject: mb/pcengines/apu1/mainboard.c: Add SMBIOS type 16 and 17 entries
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu...
PS3, Line 255: unsigned long *current)
Not really done, but I'm not going to bother you for only one instance
Really? You have not been looking at the latest patchset 😊
In the patchset 5 it was fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id73de7c2b23c6eb71722f1c78dbf0d246f429c63
Gerrit-Change-Number: 38343
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Mar 2020 09:56:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment