Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44579 )
Change subject: soc/intel/cnl: Enable HECI3 depending on devicetree
......................................................................
Patch Set 5:
What is Heci3? Is it enabled by any devicetree? is it even useful
with coreboot? If not, why not always disable it?
Heci3 is another ME interface (there are four, actually. FSP only has options for two (three?))
I guess I'll place my comments inline in the future so
they get answered before merge... Again, is enabling
Heci3 useful with coreboot? Doesn't it require additional
configuration/software?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d52096aee225c2ced1e1bc29ca850fe5073edc
Gerrit-Change-Number: 44579
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 22:21:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment