Attention is currently required from: Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41120 )
Change subject: cbfs: Add verification for RO CBFS metadata hash
......................................................................
Patch Set 19:
(1 comment)
File src/lib/Kconfig.cbfs_verification:
PS19:
No, it's used and (last time I tested, at least) it works as intended (see src/lib/metadata_hash.c).
Oh, my apologies. I didn't notice it in my grep output.
Regarding the comment above, I was referring to the file as a whole. So, #TODO comments, and WIP messages. Values CBFS_VERIFICATION and TOCTOU_SAFETY are being used in the code and at least the first one works, so TODO/WIP messages should not be there anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8930434de55eb938b042fdada9aa90218c0b5a34
Gerrit-Change-Number: 41120
Gerrit-PatchSet: 19
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 08 Dec 2021 08:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment