Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31060 )
Change subject: soc/intel/apollolake: Add GLK usb2eye configuration override ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@554 PS2, Line 554: if (!cfg->usb2eye[port].Usb20OverrideEn) : continue;
Aah I see.
https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/include/soc... File src/soc/intel/apollolake/include/soc/usb.h:
https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/include/soc... PS2, Line 33: #if IS_ENABLED(CONFIG_SOC_INTEL_GLK) I think we can remove this. It will remain unused for APL.