Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34027 )
Change subject: console: Implement j specifier in vtxprintf()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34027/2/src/console/vtxprintf.c
File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/34027/2/src/console/vtxprintf.c@131
PS2, Line 131: unsigned long long
We could make this an `uintmax_t` to proof me wrong that […]
Lol, I'll make a new patch just for that and dedicate it to you :D
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I656e3992029199b48e62a9df2d56f54c34e4e10f
Gerrit-Change-Number: 34027
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Jul 2019 03:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment