EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39366 )
Change subject: lib/spd_bin: Correct LPDDR3 SPD information
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39366/6/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39366/6/src/lib/spd_bin.c@45
PS6, Line 45: printk(BIOS_ERR,"Defaulting to using DDR4 params. Please add dram_type check for %d to %s\n",
Was this addressed? I don't see an updated patchset.
oh, I finally find the error.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39366
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9361caf272ea916a3a618ee2b72a6142ffc80c
Gerrit-Change-Number: 39366
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Mar 2020 03:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment