Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42467 )
Change subject: drivers/intel/mipi_camera: Add support for camera sensor in SSDT ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42467/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42467/2//COMMIT_MSG@7 PS2, Line 7: drivers/intel/mipi_camera: SSDT changes to handle camera sensor
Please make it a statement by adding a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 90: 0); /* endpoint */
nit: could use a macro, #define DEFAULT_ENDPOINT 0, then the comment isn't necessary
Done
https://review.coreboot.org/c/coreboot/+/42467/5/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42467/5/src/drivers/intel/mipi_came... PS5, Line 68: 0
nit: DEFAULT_ENDPOINT 😊
Done
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 39: #define CLK_FREQ_19_2MHZ 19200000 : #define CLK_FREQ_24MHZ 24000000 : #define CLK_FREQ_20MHZ 20000000
nit: line up the numbers with tabs
Done
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 109: uint8_t reserved[13];
nit: maybe a comment why this was required?
Done