Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44700 )
Change subject: soc/mediatek/mt8192: Do dramc init settings
......................................................................
Patch Set 42:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44700/41/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44700/41/src/soc/mediatek/mt8192/dr...
PS41, Line 3: #include <soc/gpio.h>
: #include <soc/dramc_pi_api.h>
: #include <soc/dramc_register.h>
: #include <string.h>
: #include <timer.h>
:
Please remove unused header files and keep only the one where you declared global_option_init and df […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4877b69de1bfa4ff981d8eb386efbddb9e0f5c2
Gerrit-Change-Number: 44700
Gerrit-PatchSet: 42
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 06:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment