[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: improve indexed register helper macros

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38577 )

Change subject: nb/intel/sandybridge: improve indexed register helper macros
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG@7 
PS1, Line 7: improve
> Personally, I don't see what the improvement is. These macros aren't about bit offsets. […]

Since the factor it gets multiplied by is a power of two and the bits where it gets shifted to are zero, this is shifting bits into their positions. The multiplication thing IMHO sort-of hides what's happening there