Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58698 )
Change subject: cpu/x86/smm: Improve smm stack setup
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/58698/comment/6aac72b0_812576a1
PS5, Line 262: return 0;
Sorry maybe an out of topic question:
does it makes sense to use 'CB_SUCCESS' and 'CB_ERR' instead of return {0,-1} ?
(sorry again for out of topic question)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58698
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bdca775550e8280757a6c5a5150a0d638d5fc2d
Gerrit-Change-Number: 58698
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 16:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment