Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34205 )
Change subject: mediatek/mt8183: add scp voltage initialization
......................................................................
Patch Set 5:
(2 comments)
Remember you have to always resolve comments before you can merge now.
https://review.coreboot.org/c/coreboot/+/34205/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34205/5//COMMIT_MSG@10
PS5, Line 10:
Hi Paul, […]
Ack
https://review.coreboot.org/c/coreboot/+/34205/4/src/soc/mediatek/mt8183/mt6...
File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/c/coreboot/+/34205/4/src/soc/mediatek/mt8183/mt6...
PS4, Line 762: }
Can you use a "static struct pmic_setting scp_setting" for this, instead? This should save a bit of […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5afb60af3c14490e20f28f1c089cfca42ddf7fcf
Gerrit-Change-Number: 34205
Gerrit-PatchSet: 5
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Aug 2019 18:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Comment-In-Reply-To: Nicolas Boichat
drinkcat@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment