Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32910 )
Change subject: src/arch/x86: Add automatic type41 entry creation ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/32910/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32910/2//COMMIT_MSG@9 PS2, Line 9: Emtries entries
https://review.coreboot.org/#/c/32910/2//COMMIT_MSG@10 PS2, Line 10: Please elaborate what type 41 entries are, and what they are needed for.
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@109 PS2, Line 109: break; Is that `break` really needed?
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@113 PS2, Line 113: Please remove this blank line.
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@1086 PS2, Line 1086: dev->bus->secondary, //bus : PCI_SLOT(dev->path.pci.devfn), //device : PCI_FUNC(dev->path.pci.devfn), //func Please add a space after `//`.
https://review.coreboot.org/#/c/32910/2/src/include/device/pci_ids.h File src/include/device/pci_ids.h:
https://review.coreboot.org/#/c/32910/2/src/include/device/pci_ids.h@21 PS2, Line 21: Use tabs for alignment (see above).
https://review.coreboot.org/#/c/32910/2/src/include/device/pci_ids.h@3085 PS2, Line 3085: Tab please.