Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40270 )
Change subject: spi: add Winbond W25Q64JW spi rom support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40270/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40270/5//COMMIT_MSG@10
PS5, Line 10: TEST=Able to boot to kernel
It should also boot without that change, shouldn’t it? Did you check that the MRC cache could be written?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I699f6d7ba3af01436f10c9a59af4a22fc45aa300
Gerrit-Change-Number: 40270
Gerrit-PatchSet: 5
Gerrit-Owner: Scott Chao
scott.chao@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Apr 2020 15:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment