Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46971 )
Change subject: soc/intel/xeon_sp; Use soc specific stack-port function ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46971/1/src/soc/intel/xeon_sp/skx/s... File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/46971/1/src/soc/intel/xeon_sp/skx/s... PS1, Line 415: : else if (port >= PORT_4A && port <= PORT_4D) : return PSTACK3; // MCP0 : else if (port >= PORT_5A && port <= PORT_5D) : return PSTACK4; // MCP1 I know this is a refactor, but it would be good to document these.