Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40727 )
Change subject: intel/gma: Only enable bus mastering if we are going to use it ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/gm45/... PS4, Line 157: if (!CONFIG(NO_GFX_INIT)) This reordering seems justified, as we need the gtt_res
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/haswe... PS4, Line 468: if (!CONFIG(NO_GFX_INIT)) Does this reordering matter?
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/sandy... PS4, Line 591: if (!CONFIG(NO_GFX_INIT)) Does this reordering matter?