[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add thermal driver

[Zhaoqing Jiu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Zhaoqing Jiu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )

Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................

Patch Set 2:

(2 comments)

File src/soc/mediatek/mt8196/mt_thermal_sram_init.c:

https://review.coreboot.org/c/coreboot/+/86017/comment/7770b97d_b8e78dd7?usp... :
PS2, Line 32: int i = 0;
            : 	uint32_t pattern = 0xffffffff;
            : 	uint32_t *buff = (uint32_t *)THERMAL_STAT_SRAM_BASE;
            : 	for (i = 0; i < THERMAL_STAT_SRAM_LEN / 4; i++) {
            : 		*buff = pattern;
            : 		buff++;
            : 	}
> I assume `memset((void *)THERMAL_STAT_SRAM_BASE, 0xFF, THERMAL_STAT_SRAM_LEN)` would be faster.

Would it be better to align the same style with thermal_cls_sram() function?

https://review.coreboot.org/c/coreboot/+/86017/comment/437e48a3_62b159b8?usp... :
PS2, Line 48: int i = 0;
            : 	uint32_t pattern = 0xffffffff;
            : 	uint32_t *buff = (uint32_t *)GPU_THERMAL_STAT_SRAM_BASE;
            : 	for (i = 0; i < GPU_THERMAL_STAT_SRAM_LEN / 4; i++) {
            : 		*buff = pattern;
            : 		buff++;
            : 	}
> Use memset?

Would it be better to align the same style with thermal_cls_sram() function?