[coreboot-gerrit] Change in coreboot[master]: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36136 )

Change subject: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP
......................................................................

Patch Set 17: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36136/17/src/soc/intel/icelake/memm... 
File src/soc/intel/icelake/memmap.c:

https://review.coreboot.org/c/coreboot/+/36136/17/src/soc/intel/icelake/memm... 
PS17, Line 239: /*
              : 	 * Check if Tseg has been initialized, we will use this as a flag
              : 	 * to check if the MRC is done, and only then continue to read the
              : 	 * PRMMR_BASE MSR. The system hangs if PRMRR_BASE MSR is read before
              : 	 * PRMRR_MASK MSR lock bit is set.
              : 	 */
              : 	if (sa_get_tseg_base() == 0)
              : 		return NULL;
Do this in a separate commit or add to the commit message? See CB:36334