EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35113 )
Change subject: mb/google/drallion: add dummy SPD file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli...
PS2, Line 11:
Will this change to SPD work with the Arcada and Sarien variants?
Yes, but no harm. I can boot with my Sarien. We read SPD from eeprom. I put the dummy as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife59c2dd689d72b117f30e832a3ce7eed4fa4220
Gerrit-Change-Number: 35113
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 16:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment