24 May
2019
24 May
'19
10:51 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32990 )
Change subject: superio/fintek/f71863fg: Remove variable set but not used ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32990/1/src/superio/fintek/f71863fg/superio.... File src/superio/fintek/f71863fg/superio.c:
https://review.coreboot.org/#/c/32990/1/src/superio/fintek/f71863fg/superio.... PS1, Line 32: find_resource(dev, PNP_IDX_IO0); hmm, this function call is an "interesting" way to make sure that PNP_IDX_IO0 is set (the function calls die("") when it isn't)
--
To view, visit https://review.coreboot.org/c/coreboot/+/32990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993055d237b2bd607822485d34d5508c74a7744c
Gerrit-Change-Number: 32990
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 May 2019 17:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment