Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33194 )
Change subject: mb/google/{hatch, sarien, arcada}: Make HECI1 chip config disable
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33194/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33194/6//COMMIT_MSG@7
PS6, Line 7: mb/google/{hatch, sarien, arcada}: Make HECI1 chip config disable
Can you please add a comment indicating that this is not actually disabling Heci and it requires some more changes to cannonlake SoC code to set the right UPDs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia88f3315a9dc3365d0acc13ed887e7c596c97c91
Gerrit-Change-Number: 33194
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Jun 2019 05:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment