Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44973 )
Change subject: src/vendorcode/intel/fsp/fsp2_0/cpx-sp: add prev boot error info HOB header file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44973/2/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_prevbooterr.h:
https://review.coreboot.org/c/coreboot/+/44973/2/src/vendorcode/intel/fsp/fs...
PS2, Line 2: BR
Maybe someone should tell Intel about these cosmetic horrors? 😄
This is a doxygen marker. That being said, there are many cosmetic horrors.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b88af17075b98e88c7e94e55fea37627ec03cd0
Gerrit-Change-Number: 44973
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 17:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment