Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 4:
(2 comments)
looks good to me in general, but I'd like to have a bit easier to understand API that I wrote about in the other patch
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... File src/mainboard/facebook/fbg1701/mainboard.h:
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 21: number_of_databytes payload_length maybe?
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 23: u8 offset; /* register address [15:8] */ : u8 data[5]; /* First byte is register address [7:0] */ I'd merge those two. See my comments on the API on the Braswell I2C write patch.