Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Arthur Heymans, Andrey Petrov, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Christian Walter, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Fred Reitberger, Alexander Couzens, Werner Zeh, Tim Chu, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62619 )
Change subject: Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I80f1b65071c2c7dec2c73a208bf4a9f5d11a6ccb
......................................................................
Patch Set 1:
(6 comments)
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/8eab3486_199487bd
PS1, Line 2117: #define PCI_VID_AKS 0x416c
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/88f643ab_fb0c280c
PS1, Line 2118: #define PCI_DID_AKS_ALADDINCARD 0x0100
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/b447518c_d2098687
PS1, Line 2119: #define PCI_DID_AKS_CPC 0x0200
'AKS' may be misspelled - perhaps 'ASK'?
File src/soc/intel/skylake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/aa51e8e8_cb30a78f
PS1, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) {
code indent should use tabs where possible
File src/southbridge/amd/agesa/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/4d7dbe3d_67a78216
PS1, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
File src/southbridge/amd/pi/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143234):
https://review.coreboot.org/c/coreboot/+/62619/comment/0d0697c9_de31d9d7
PS1, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62619
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80f1b65071c2c7dec2c73a208bf4a9f5d11a6ccb
Gerrit-Change-Number: 62619
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 06 Mar 2022 15:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment