Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37809 )
Change subject: cpu/x86/smm: Fix regression with SMM setup
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I suggest backing out the field addtions to the struct itself. There's honestly no good reason to add fields to things that aren't actually used in the code. That or revert the original patch.
The fields are used for the STM setup and, hence will be used when the remainder of the STM setup code is merged
Correct. And those field additions should go along w/ the patch that adds the functionality.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f8a9898cf81349b50a050b2c2f92578205573e4
Gerrit-Change-Number: 37809
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Name of user not set #1002358
Gerrit-Comment-Date: Wed, 18 Dec 2019 17:09:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment