Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )
Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/... PS1, Line 196: # VR Slew rate setting : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRateForIa" = "2" : register "SlowSlewRateForGt" = "2" : register "SlowSlewRateForSa" = "2" : register "FastPkgCRampDisableIa" = "1" : register "FastPkgCRampDisableGt" = "1" : register "FastPkgCRampDisableSa" = "1" I believe these are currently required only for hatch variant. So, it would be good to add these to hatch/overridetree.cb