Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31050 )
Change subject: src: Fix the warning "type 'hex' are always defined"
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31050/4/src/arch/x86/include/arch/memlayout....
File src/arch/x86/include/arch/memlayout.h:
https://review.coreboot.org/#/c/31050/4/src/arch/x86/include/arch/memlayout....
PS4, Line 26: CONFIG_RAMTOP
Isn't this sort of thing supposed to be using IS_ENABLED()? I thought that's what it was for.
AFAIR IS_ENABLED() only works with booleans.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfda267936a23d9d14832116d67571f42f685906
Gerrit-Change-Number: 31050
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 24 Jan 2019 21:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment