Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85015?usp=email )
Change subject: mb/google/nissa/var/rull: Add ELAN touchscreen to devicetree ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85015/comment/0ea6daa5_2c394c60?usp... : PS6, Line 7: Elan
ELAN
Done
https://review.coreboot.org/c/coreboot/+/85015/comment/4c6f386c_6cf60816?usp... : PS6, Line 7: Add Elan touchscreen
… to devicetree
Done
https://review.coreboot.org/c/coreboot/+/85015/comment/f89817f9_bcfed1f3?usp... : PS6, Line 9: Add Elan touchscreen override devicetree for rull based on the latest schematic NB7559_MB_SCH_V1_2024_1010.pdf.
Please wrap the line after 72 characters.
Done
https://review.coreboot.org/c/coreboot/+/85015/comment/eba010af_5038a87b?usp... : PS6, Line 13: touchpanel function is normal
What commands did you run? xev? Any log line, one could check?
Done
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85015/comment/e80cdf18_747ee9c3?usp... : PS6, Line 232: register "generic.stop_delay_ms" = "150"
Is 150 ms mentioned in the schematics or some datasheet?
Refer to the parameters submitted by the same touch IC, I asked the vendor and they also gave similar reference values.