Attention is currently required from: Angel Pons, Christian Walter, Elyes Haouas, Julius Werner, Maxim, Michał Żygowski, Philipp Hug, Piotr Król, Sean Rhodes, Uwe Poeche, Werner Zeh, ron minnich.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81455?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: tree: Remove blank lines before '}' and after '{'
......................................................................
Patch Set 2:
(1 comment)
File util/intelp2m/parser/parser.go:
https://review.coreboot.org/c/coreboot/+/81455/comment/0c682646_750de282 :
PS2, Line 54: if !strings.Contains(info.function, "GPIO Community 0") {
this is likely unrelated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81455?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46a362270f69d0a4a28e5bb9c954f34d632815ff
Gerrit-Change-Number: 81455
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maxim
max.senia.poliak@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 09 Apr 2024 09:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment