Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48682
to look at the new patch set (#2).
Change subject: soc/intel/common/block/pcie/rtd3: Make changes to support S3 ......................................................................
soc/intel/common/block/pcie/rtd3: Make changes to support S3
The RTD3 ACPI _ON method will unconditionally attempt to re-initialize the device, setting up GPIOs, clocks, and the L23 ready exit flow.
When using S3 instead of S0ix this work is not needed and instead results in the device disappearing and the resume failing in the OS.
BUG=b:174776411 TEST=test S3 and S0ix on volteer device with both NVMe and SD using the RTD3 driver to ensure suspend/resume works in both cases.
Signed-off-by: Duncan Laurie dlaurie@google.com Change-Id: I6bd7d001890939850381858fe663366472aacefc --- M src/soc/intel/common/block/pcie/rtd3/rtd3.c 1 file changed, 37 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/48682/2