Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35152 )
Change subject: drivers/ipmi/ipmi_kcs_ops: Advertise correct register spacing ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35152/2/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/35152/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 134: addr.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
should be addr. […]
Done
https://review.coreboot.org/c/coreboot/+/35152/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 198: acpigen_write_io16(dev->path.pnp.port, dev->path.pnp.port, 1, 2, 1);
should be: […]
Done
https://review.coreboot.org/c/coreboot/+/35152/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 253: register_spacing = 0 << 6;
reg_spacing is not used
Done
https://review.coreboot.org/c/coreboot/+/35152/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 265: 0,
add reg_spacing here
Done