Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33160 )
Change subject: qcs405: Add board_config entry in the interface table ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33160/6/src/mainboard/google/mistra... File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/c/coreboot/+/33160/6/src/mainboard/google/mistra... PS6, Line 41: *_buck_type = ext_buck;
We should not directly manipulate this memory from here. […]
Done
https://review.coreboot.org/c/coreboot/+/33160/6/src/soc/qualcomm/common/inc... File src/soc/qualcomm/common/include/soc/qclib_common.h:
https://review.coreboot.org/c/coreboot/+/33160/6/src/soc/qualcomm/common/inc... PS6, Line 39: #define QCLIB_TE_BUCK_TYPE "buck_type"
Can we make this something a little more generic? Because it's really chipset-specific hardware conf […]
Done