12 Sep
2019
12 Sep
'19
5:40 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35372 )
Change subject: intel/nehalem: Refactor ACPI S3 detection ......................................................................
Patch Set 1:
Patch Set 1:
there are no boards that use elog on nehalem. I'd recommend to remove the whole elog code on this platform instead.
ELOG depends on BOOT_DEVICE_SUPPORTS_WRITES, so everything ELOG -related under southbridge/intel and northbridge/intel never builds. Looks like a regression from CB:16204?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib405f3c3a6143e972963307eef7371dd43b9b5fc
Gerrit-Change-Number: 35372
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 12 Sep 2019 11:40:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment