Attention is currently required from: Derek Huang, Joey Peng, Paul Menzel, Reka Norman.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )
Change subject: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/dedede/variants/boxy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78146/comment/2ad3bbe4_1ebd869b :
PS8, Line 68:
new patch 9 for configuring GPIO_HDMI_HPD to input and get correct state.
Done
https://review.coreboot.org/c/coreboot/+/78146/comment/ce9a61e1_45442885 :
PS8, Line 69: if (display_init_required()
: && !gpio_get(GPIO_USB_C0_HPD)) {
: /* This has to be done before FSP-S runs. */
: wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms);
: } else if (display_init_required()
: && !gpio_get(GPIO_USB_C1_HPD)) {
: /* This has to be done before FSP-S runs. */
: wait_for_hpd(GPIO_USB_C1_HPD, display_timeout_ms);
: }
Upload patch 9 to remove wait_for_hpd() and add 3s delay directly with non-HDMI display case due to […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208fdf8234886b2ef43a4b972e6682892238e8e9
Gerrit-Change-Number: 78146
Gerrit-PatchSet: 9
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 07 Oct 2023 14:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-MessageType: comment