Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: drivers: Replace a few set_vbe_mode_info_valid
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39004/8/src/soc/nvidia/tegra210/dc....
File src/soc/nvidia/tegra210/dc.c:
https://review.coreboot.org/c/coreboot/+/39004/8/src/soc/nvidia/tegra210/dc....
PS8, Line 233: bytes_per_line, config->framebuffer_bits_per_pixel);
Isn't this missing the row alignment field?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95d1d62385a201c68c6c2527c023ad2292a235c5
Gerrit-Change-Number: 39004
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Mar 2020 22:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment