Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38534 )
Change subject: mb/emulation/qemu-aarch64: Add MMU support
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38534/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38534/2//COMMIT_MSG@10
PS2, Line 10: active
activate ?
Done
https://review.coreboot.org/c/coreboot/+/38534/2/src/mainboard/emulation/qem...
File src/mainboard/emulation/qemu-aarch64/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38534/2/src/mainboard/emulation/qem...
PS2, Line 12: *
please remove this empty line
Done
https://review.coreboot.org/c/coreboot/+/38534/2/src/mainboard/emulation/qem...
File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/38534/2/src/mainboard/emulation/qem...
PS2, Line 32: 1M)
That's unusually large?
Reduced to 128K
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifaed9d3cc11520f180a732d51adce634621b5844
Gerrit-Change-Number: 38534
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 11:08:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment