Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32031 )
Change subject: chromeos: update old boards to use lb_add_gpios notation ......................................................................
Patch Set 2:
(2 comments)
LGTM but Kyösti made some good suggestions.
https://review.coreboot.org/#/c/32031/2/src/mainboard/google/butterfly/chrom... File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/#/c/32031/2/src/mainboard/google/butterfly/chrom... PS2, Line 39: /* Write Protect: GPIO active Low */ nit: not sure if we still need these comments everywhere because with the shorter notation it's all pretty self-explanatory
https://review.coreboot.org/#/c/32031/2/src/mainboard/samsung/lumpy/chromeos... File src/mainboard/samsung/lumpy/chromeos.c:
https://review.coreboot.org/#/c/32031/2/src/mainboard/samsung/lumpy/chromeos... PS2, Line 101: pci_write_config32(dev, SATA_SP, flags);
Just curious, why do we stash the GPIO states here? Looked like some other boards do not.
No idea... Lumpy is a really old board, quite possible this is no longer used but probably not worth worrying about.