Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 6:
(3 comments)
File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/c/coreboot/+/79106/comment/b41f5134_c7f89f35 :
PS5, Line 55: static uint64_t cache_numsets(const enum cache_level level, const enum cache_type type)
: {
: cache_select(level, type);
:
: /* (Number of sets in cache) - 1 */
: return get_ccsidr_el1_numsets(raw_read_ccsidr_el1()) + 1;
: }
I agree. […]
Done
https://review.coreboot.org/c/coreboot/+/79106/comment/a61d0855_22d7b0e5 :
PS5, Line 87: (struct cache_info) {
This will also memcpy 0 to .size first before updating it. […]
Done
https://review.coreboot.org/c/coreboot/+/79106/comment/96ebdc7c_463cb4ad :
PS5, Line 88:
No newline after {
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 6
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Comment-Date: Wed, 13 Dec 2023 18:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment