Attention is currently required from: Nico Huber, Arthur Heymans, Kyösti Mälkki, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64009 )
Change subject: nb/amd/agesa/family14: Clean up fx_devs stuff ......................................................................
Patch Set 1:
(4 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/64009/comment/2f32e861_44c10b1a PS1, Line 78: if (fx_devs == 0)
Not needed anymore.
I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010
https://review.coreboot.org/c/coreboot/+/64009/comment/0288cc7c_ed4b313a PS1, Line 86: if (fx_devs == 0)
Dito.
I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010
https://review.coreboot.org/c/coreboot/+/64009/comment/dc4499f2_aee701d6 PS1, Line 88: for (i = 0; i < fx_devs; i++) {
Also not needed anymore.
I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010
https://review.coreboot.org/c/coreboot/+/64009/comment/13d62836_a1c898c4 PS1, Line 460: base = f1_read_config32(reg); : limit = f1_read_config32(reg + 0x04);
NB. […]
I don't know, maybe AGESA did. But it might also be copy-pasta, I haven't checked.