Attention is currently required from: Nico Huber, Arthur Heymans, Kyösti Mälkki, Felix Held.

View Change

4 comments:

• File src/northbridge/amd/agesa/family14/northbridge.c:

  • Patch Set #1, Line 78: if (fx_devs == 0)

    Not needed anymore.

    I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010

  • Patch Set #1, Line 86: if (fx_devs == 0)

    Dito.

    I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010

  • Patch Set #1, Line 88: for (i = 0; i < fx_devs; i++) {

    Also not needed anymore.

    I'm not sure if fx_devs have been populated when this gets called. In any case, this is dropped in CB:64010

  • Patch Set #1, Line 460:

    		base = f1_read_config32(reg);
    		limit = f1_read_config32(reg + 0x04);
    

    NB. […]

    I don't know, maybe AGESA did. But it might also be copy-pasta, I haven't checked.

To view, visit change 64009. To unsubscribe, or for help writing mail filters, visit settings.