Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35502 )
Change subject: sc7180: Add AOP firmware support ......................................................................
Patch Set 14: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in... PS11, Line 70: REGION(dram_aop, 0x80800000, 0x040000, 0x1000)
I can't speak to why this is different between Rennell and Napali other than cite hardware deltas. […]
Hmm... looks like I don't have that document, the memory map we were given only goes up to 0x10000000. But okay, if this is a standardized location on this SoC there's nothing wrong with that, I'm just curious where it suddenly came from (because the two chips are so similar otherwise).
With the code we have in depthcharge right now the remaining 756KB hole here will not be passed through to the kernel anyway, because we align everything by 1MB. Maybe we should change that (it's not really necessary anymore).