Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44165 )
Change subject: superio/ite: configure EC for fans to full at thermal limit
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44165/1/src/mainboard/asus/f2a85-m/...
File src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb:
https://review.coreboot.org/c/coreboot/+/44165/1/src/mainboard/asus/f2a85-m/...
PS1, Line 52: register "FAN1.smart.full_lmt" = "0"
Thanks! I was unsure about that. […]
I'd drop it to make this change more localized and so that this change doesn't conflict as much with other unrelated changes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74102ac0d54be33558c161c9c84594d121772b1
Gerrit-Change-Number: 44165
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 22:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Büchler
michael.buechler@posteo.net
Gerrit-MessageType: comment